Coverage Report

Created: 2026-04-29 19:21

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
/tmp/bitcoin/src/common/config.cpp
Line
Count
Source
1
// Copyright (c) 2023-present The Bitcoin Core developers
2
// Distributed under the MIT software license, see the accompanying
3
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
4
5
#include <common/args.h>
6
7
#include <common/settings.h>
8
#include <logging.h>
9
#include <sync.h>
10
#include <tinyformat.h>
11
#include <univalue.h>
12
#include <util/chaintype.h>
13
#include <util/fs.h>
14
#include <util/string.h>
15
16
#include <algorithm>
17
#include <cassert>
18
#include <cstdlib>
19
#include <filesystem>
20
#include <fstream>
21
#include <iostream>
22
#include <sstream>
23
#include <list>
24
#include <map>
25
#include <memory>
26
#include <optional>
27
#include <string>
28
#include <string_view>
29
#include <utility>
30
#include <vector>
31
32
using util::TrimString;
33
using util::TrimStringView;
34
35
static bool GetConfigOptions(std::istream& stream, const std::string& filepath, std::string& error, std::vector<std::pair<std::string, std::string>>& options, std::list<SectionInfo>& sections)
36
51.1k
{
37
51.1k
    std::string str, prefix;
38
51.1k
    std::string::size_type pos;
39
51.1k
    int linenr = 1;
40
288k
    while (std::getline(stream, str)) {
41
237k
        bool used_hash = false;
42
237k
        if ((pos = str.find('#')) != std::string::npos) {
43
26
            str = str.substr(0, pos);
44
26
            used_hash = true;
45
26
        }
46
237k
        const static std::string pattern = " \t\r\n";
47
237k
        str = TrimString(str, pattern);
48
237k
        if (!str.empty()) {
49
237k
            if (*str.begin() == '[' && *str.rbegin() == ']') {
50
2.27k
                const std::string section = str.substr(1, str.size() - 2);
51
2.27k
                sections.emplace_back(SectionInfo{section, filepath, linenr});
52
2.27k
                prefix = section + '.';
53
235k
            } else if (*str.begin() == '-') {
54
1
                error = strprintf("parse error on line %i: %s, options in configuration file must be specified without leading -", linenr, str);
55
1
                return false;
56
235k
            } else if ((pos = str.find('=')) != std::string::npos) {
57
235k
                std::string name = prefix + TrimString(std::string_view{str}.substr(0, pos), pattern);
58
235k
                std::string_view value = TrimStringView(std::string_view{str}.substr(pos + 1), pattern);
59
235k
                if (used_hash && name.find("rpcpassword") != std::string::npos) {
60
3
                    error = strprintf("parse error on line %i, using # in rpcpassword can be ambiguous and should be avoided", linenr);
61
3
                    return false;
62
3
                }
63
235k
                options.emplace_back(name, value);
64
235k
                if ((pos = name.rfind('.')) != std::string::npos && prefix.length() <= pos) {
65
91.3k
                    sections.emplace_back(SectionInfo{name.substr(0, pos), filepath, linenr});
66
91.3k
                }
67
235k
            } else {
68
2
                error = strprintf("parse error on line %i: %s", linenr, str);
69
2
                if (str.size() >= 2 && str.starts_with("no")) {
70
1
                    error += strprintf(", if you intended to specify a negated option, use %s=1 instead", str);
71
1
                }
72
2
                return false;
73
2
            }
74
237k
        }
75
237k
        ++linenr;
76
237k
    }
77
51.1k
    return true;
78
51.1k
}
79
80
235k
bool IsConfSupported(KeyInfo& key, std::string& error) {
81
235k
    if (key.name == "conf") {
82
2
        error = "conf cannot be set in the configuration file; use includeconf= if you want to include additional config files";
83
2
        return false;
84
2
    }
85
235k
    if (key.name == "reindex") {
86
        // reindex can be set in a config file but it is strongly discouraged as this will cause the node to reindex on
87
        // every restart. Allow the config but throw a warning
88
1
        LogWarning("reindex=1 is set in the configuration file, which will significantly slow down startup. Consider removing or commenting out this option for better performance, unless there is currently a condition which makes rebuilding the indexes necessary");
89
1
        return true;
90
1
    }
91
235k
    return true;
92
235k
}
93
94
bool ArgsManager::ReadConfigStream(std::istream& stream, const std::string& filepath, std::string& error, bool ignore_invalid_keys)
95
51.1k
{
96
51.1k
    LOCK(cs_args);
97
51.1k
    std::vector<std::pair<std::string, std::string>> options;
98
51.1k
    if (!GetConfigOptions(stream, filepath, error, options, m_config_sections)) {
99
6
        return false;
100
6
    }
101
235k
    for (const std::pair<std::string, std::string>& option : options) {
102
235k
        KeyInfo key = InterpretKey(option.first);
103
235k
        std::optional<unsigned int> flags = GetArgFlags_('-' + key.name);
104
235k
        if (!IsConfSupported(key, error)) return false;
105
235k
        if (flags) {
106
213k
            std::optional<common::SettingsValue> value = InterpretValue(key, &option.second, *flags, error);
107
213k
            if (!value) {
108
0
                return false;
109
0
            }
110
213k
            m_settings.ro_config[key.section][key.name].push_back(*value);
111
213k
        } else {
112
21.9k
            if (ignore_invalid_keys) {
113
21.9k
                LogWarning("Ignoring unknown configuration value %s", option.first);
114
21.9k
            } else {
115
0
                error = strprintf("Invalid configuration value %s", option.first);
116
0
                return false;
117
0
            }
118
21.9k
        }
119
235k
    }
120
51.1k
    return true;
121
51.1k
}
122
123
bool ArgsManager::ReadConfigString(const std::string& str_config)
124
14
{
125
14
    std::istringstream streamConfig(str_config);
126
14
    {
127
14
        LOCK(cs_args);
128
14
        m_settings.ro_config.clear();
129
14
        m_config_sections.clear();
130
14
    }
131
14
    std::string error;
132
14
    return ReadConfigStream(streamConfig, "", error);
133
14
}
134
135
bool ArgsManager::ReadConfigFiles(std::string& error, bool ignore_invalid_keys)
136
2.26k
{
137
2.26k
    {
138
2.26k
        LOCK(cs_args);
139
2.26k
        m_settings.ro_config.clear();
140
2.26k
        m_config_sections.clear();
141
2.26k
        const auto conf_val = GetPathArg_("-conf", BITCOIN_CONF_FILENAME);
142
2.26k
        m_config_path = (conf_val.is_absolute() || conf_val.empty()) ? conf_val : fsbridge::AbsPathJoin(GetDataDir(/*net_specific=*/false), conf_val);
143
2.26k
    }
144
145
2.26k
    const auto conf_path{GetConfigFilePath()};
146
2.26k
    std::ifstream stream;
147
2.26k
    if (!conf_path.empty()) { // path is empty when -noconf is specified
148
2.26k
        if (fs::is_directory(conf_path)) {
149
1
            error = strprintf("Config file \"%s\" is a directory.", fs::PathToString(conf_path));
150
1
            return false;
151
1
        }
152
2.26k
        stream = std::ifstream{conf_path.std_path()};
153
        // If the file is explicitly specified, it must be readable
154
2.26k
        if (IsArgSet("-conf") && !stream.good()) {
155
1
            error = strprintf("specified config file \"%s\" could not be opened.", fs::PathToString(conf_path));
156
1
            return false;
157
1
        }
158
2.26k
    }
159
    // ok to not have a config file
160
2.26k
    if (stream.good()) {
161
2.26k
        if (!ReadConfigStream(stream, fs::PathToString(conf_path), error, ignore_invalid_keys)) {
162
2
            return false;
163
2
        }
164
        // `-includeconf` cannot be included in the command line arguments except
165
        // as `-noincludeconf` (which indicates that no included conf file should be used).
166
2.26k
        bool use_conf_file{true};
167
2.26k
        {
168
2.26k
            LOCK(cs_args);
169
2.26k
            if (auto* includes = common::FindKey(m_settings.command_line_options, "includeconf")) {
170
                // ParseParameters() fails if a non-negated -includeconf is passed on the command-line
171
0
                assert(common::SettingsSpan(*includes).last_negated());
172
0
                use_conf_file = false;
173
0
            }
174
2.26k
        }
175
2.26k
        if (use_conf_file) {
176
2.26k
            std::string chain_id = GetChainTypeString();
177
2.26k
            std::vector<std::string> conf_file_names;
178
179
9.03k
            auto add_includes = [&](const std::string& network, size_t skip = 0) {
180
9.03k
                size_t num_values = 0;
181
9.03k
                LOCK(cs_args);
182
9.03k
                if (auto* section = common::FindKey(m_settings.ro_config, network)) {
183
9.00k
                    if (auto* values = common::FindKey(*section, "includeconf")) {
184
60
                        for (size_t i = std::max(skip, common::SettingsSpan(*values).negated()); i < values->size(); ++i) {
185
27
                            conf_file_names.push_back((*values)[i].get_str());
186
27
                        }
187
33
                        num_values = values->size();
188
33
                    }
189
9.00k
                }
190
9.03k
                return num_values;
191
9.03k
            };
192
193
            // We haven't set m_network yet (that happens in SelectParams()), so manually check
194
            // for network.includeconf args.
195
2.26k
            const size_t chain_includes = add_includes(chain_id);
196
2.26k
            const size_t default_includes = add_includes({});
197
198
2.26k
            for (const std::string& conf_file_name : conf_file_names) {
199
26
                const auto include_conf_path{AbsPathForConfigVal(*this, fs::PathFromString(conf_file_name), /*net_specific=*/false)};
200
26
                if (fs::is_directory(include_conf_path)) {
201
1
                    error = strprintf("Included config file \"%s\" is a directory.", fs::PathToString(include_conf_path));
202
1
                    return false;
203
1
                }
204
25
                std::ifstream conf_file_stream{include_conf_path.std_path()};
205
25
                if (conf_file_stream.good()) {
206
24
                    if (!ReadConfigStream(conf_file_stream, conf_file_name, error, ignore_invalid_keys)) {
207
6
                        return false;
208
6
                    }
209
18
                    LogInfo("Included configuration file %s\n", conf_file_name);
210
18
                } else {
211
1
                    error = "Failed to include configuration file " + conf_file_name;
212
1
                    return false;
213
1
                }
214
25
            }
215
216
            // Warn about recursive -includeconf
217
2.25k
            conf_file_names.clear();
218
2.25k
            add_includes(chain_id, /* skip= */ chain_includes);
219
2.25k
            add_includes({}, /* skip= */ default_includes);
220
2.25k
            std::string chain_id_final = GetChainTypeString();
221
2.25k
            if (chain_id_final != chain_id) {
222
                // Also warn about recursive includeconf for the chain that was specified in one of the includeconfs
223
0
                add_includes(chain_id_final);
224
0
            }
225
2.25k
            for (const std::string& conf_file_name : conf_file_names) {
226
1
                tfm::format(std::cerr, "warning: -includeconf cannot be used from included files; ignoring -includeconf=%s\n", conf_file_name);
227
1
            }
228
2.25k
        }
229
2.26k
    }
230
231
    // If datadir is changed in .conf file:
232
2.25k
    ClearPathCache();
233
2.25k
    if (!CheckDataDirOption(*this)) {
234
1
        error = strprintf("specified data directory \"%s\" does not exist.", GetArg("-datadir", ""));
235
1
        return false;
236
1
    }
237
2.25k
    return true;
238
2.25k
}
239
240
fs::path AbsPathForConfigVal(const ArgsManager& args, const fs::path& path, bool net_specific)
241
9.63k
{
242
9.63k
    if (path.is_absolute() || path.empty()) {
243
80
        return path;
244
80
    }
245
9.55k
    return fsbridge::AbsPathJoin(net_specific ? args.GetDataDirNet() : args.GetDataDirBase(), path);
246
9.63k
}