Coverage Report

Created: 2026-04-29 19:21

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
/tmp/bitcoin/src/blockencodings.cpp
Line
Count
Source
1
// Copyright (c) 2016-present The Bitcoin Core developers
2
// Distributed under the MIT software license, see the accompanying
3
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
4
5
#include <blockencodings.h>
6
#include <chainparams.h>
7
#include <common/system.h>
8
#include <consensus/consensus.h>
9
#include <consensus/validation.h>
10
#include <crypto/sha256.h>
11
#include <crypto/siphash.h>
12
#include <logging.h>
13
#include <random.h>
14
#include <streams.h>
15
#include <txmempool.h>
16
#include <validation.h>
17
18
#include <unordered_map>
19
20
CBlockHeaderAndShortTxIDs::CBlockHeaderAndShortTxIDs(const CBlock& block, uint64_t nonce)
21
73.7k
    : nonce(nonce),
22
73.7k
      shorttxids(block.vtx.size() - 1),
23
73.7k
      prefilledtxn(1),
24
73.7k
      header(block)
25
73.7k
{
26
73.7k
    FillShortTxIDSelector();
27
    // TODO: Use our mempool prior to block acceptance to predictively fill more than just the coinbase
28
73.7k
    prefilledtxn[0] = {0, block.vtx[0]};
29
122k
    for (size_t i = 1; i < block.vtx.size(); i++) {
30
48.8k
        const CTransaction& tx = *block.vtx[i];
31
48.8k
        shorttxids[i - 1] = GetShortID(tx.GetWitnessHash());
32
48.8k
    }
33
73.7k
}
34
35
void CBlockHeaderAndShortTxIDs::FillShortTxIDSelector() const
36
93.9k
{
37
93.9k
    DataStream stream{};
38
93.9k
    stream << header << nonce;
39
93.9k
    CSHA256 hasher;
40
93.9k
    hasher.Write((unsigned char*)&(*stream.begin()), stream.end() - stream.begin());
41
93.9k
    uint256 shorttxidhash;
42
93.9k
    hasher.Finalize(shorttxidhash.begin());
43
93.9k
    m_hasher.emplace(shorttxidhash.GetUint64(0), shorttxidhash.GetUint64(1));
44
93.9k
}
45
46
uint64_t CBlockHeaderAndShortTxIDs::GetShortID(const Wtxid& wtxid) const
47
150k
{
48
150k
    static_assert(SHORTTXIDS_LENGTH == 6, "shorttxids calculation assumes 6-byte shorttxids");
49
150k
    return (*Assert(m_hasher))(wtxid.ToUint256()) & 0xffffffffffffL;
50
150k
}
51
52
/* Reconstructing a compact block is in the hot-path for block relay,
53
 * so we want to do it as quickly as possible. Because this often
54
 * involves iterating over the entire mempool, we put all the data we
55
 * need (ie the wtxid and a reference to the actual transaction data)
56
 * in a vector and iterate over the vector directly. This allows optimal
57
 * CPU caching behaviour, at a cost of only 40 bytes per transaction.
58
 */
59
ReadStatus PartiallyDownloadedBlock::InitData(const CBlockHeaderAndShortTxIDs& cmpctblock, const std::vector<std::pair<Wtxid, CTransactionRef>>& extra_txn)
60
16.8k
{
61
16.8k
    LogDebug(BCLog::CMPCTBLOCK, "Initializing PartiallyDownloadedBlock for block %s using a cmpctblock of %u bytes\n", cmpctblock.header.GetHash().ToString(), GetSerializeSize(cmpctblock));
62
16.8k
    if (cmpctblock.header.IsNull() || (cmpctblock.shorttxids.empty() && cmpctblock.prefilledtxn.empty()))
63
0
        return READ_STATUS_INVALID;
64
16.8k
    if (cmpctblock.shorttxids.size() + cmpctblock.prefilledtxn.size() > MAX_BLOCK_WEIGHT / MIN_SERIALIZABLE_TRANSACTION_WEIGHT)
65
0
        return READ_STATUS_INVALID;
66
67
16.8k
    if (!header.IsNull() || !txn_available.empty()) return READ_STATUS_INVALID;
68
69
16.8k
    header = cmpctblock.header;
70
16.8k
    txn_available.resize(cmpctblock.BlockTxCount());
71
72
16.8k
    int32_t lastprefilledindex = -1;
73
33.7k
    for (size_t i = 0; i < cmpctblock.prefilledtxn.size(); i++) {
74
16.8k
        if (cmpctblock.prefilledtxn[i].tx->IsNull())
75
0
            return READ_STATUS_INVALID;
76
77
16.8k
        lastprefilledindex += cmpctblock.prefilledtxn[i].index + 1; //index is a uint16_t, so can't overflow here
78
16.8k
        if (lastprefilledindex > std::numeric_limits<uint16_t>::max())
79
0
            return READ_STATUS_INVALID;
80
16.8k
        if ((uint32_t)lastprefilledindex > cmpctblock.shorttxids.size() + i) {
81
            // If we are inserting a tx at an index greater than our full list of shorttxids
82
            // plus the number of prefilled txn we've inserted, then we have txn for which we
83
            // have neither a prefilled txn or a shorttxid!
84
1
            return READ_STATUS_INVALID;
85
1
        }
86
16.8k
        txn_available[lastprefilledindex] = cmpctblock.prefilledtxn[i].tx;
87
16.8k
    }
88
16.8k
    prefilled_count = cmpctblock.prefilledtxn.size();
89
90
    // Calculate map of txids -> positions and check mempool to see what we have (or don't)
91
    // Because well-formed cmpctblock messages will have a (relatively) uniform distribution
92
    // of short IDs, any highly-uneven distribution of elements can be safely treated as a
93
    // READ_STATUS_FAILED.
94
16.8k
    std::unordered_map<uint64_t, uint16_t> shorttxids(cmpctblock.shorttxids.size());
95
16.8k
    uint16_t index_offset = 0;
96
30.1k
    for (size_t i = 0; i < cmpctblock.shorttxids.size(); i++) {
97
14.2k
        while (txn_available[i + index_offset])
98
935
            index_offset++;
99
13.2k
        shorttxids[cmpctblock.shorttxids[i]] = i + index_offset;
100
        // To determine the chance that the number of entries in a bucket exceeds N,
101
        // we use the fact that the number of elements in a single bucket is
102
        // binomially distributed (with n = the number of shorttxids S, and p =
103
        // 1 / the number of buckets), that in the worst case the number of buckets is
104
        // equal to S (due to std::unordered_map having a default load factor of 1.0),
105
        // and that the chance for any bucket to exceed N elements is at most
106
        // buckets * (the chance that any given bucket is above N elements).
107
        // Thus: P(max_elements_per_bucket > N) <= S * (1 - cdf(binomial(n=S,p=1/S), N)).
108
        // If we assume blocks of up to 16000, allowing 12 elements per bucket should
109
        // only fail once per ~1 million block transfers (per peer and connection).
110
13.2k
        if (shorttxids.bucket_size(shorttxids.bucket(cmpctblock.shorttxids[i])) > 12)
111
0
            return READ_STATUS_FAILED;
112
13.2k
    }
113
16.8k
    if (shorttxids.size() != cmpctblock.shorttxids.size())
114
0
        return READ_STATUS_FAILED; // Short ID collision
115
116
16.8k
    std::vector<bool> have_txn(txn_available.size());
117
16.8k
    {
118
16.8k
    LOCK(pool->cs);
119
91.2k
    for (const auto& [wtxid, txit] : pool->txns_randomized) {
120
91.2k
        uint64_t shortid = cmpctblock.GetShortID(wtxid);
121
91.2k
        std::unordered_map<uint64_t, uint16_t>::iterator idit = shorttxids.find(shortid);
122
91.2k
        if (idit != shorttxids.end()) {
123
11.3k
            if (!have_txn[idit->second]) {
124
11.3k
                txn_available[idit->second] = txit->GetSharedTx();
125
11.3k
                have_txn[idit->second]  = true;
126
11.3k
                mempool_count++;
127
11.3k
            } else {
128
                // If we find two mempool txn that match the short id, just request it.
129
                // This should be rare enough that the extra bandwidth doesn't matter,
130
                // but eating a round-trip due to FillBlock failure would be annoying
131
0
                if (txn_available[idit->second]) {
132
0
                    txn_available[idit->second].reset();
133
0
                    mempool_count--;
134
0
                }
135
0
            }
136
11.3k
        }
137
        // Though ideally we'd continue scanning for the two-txn-match-shortid case,
138
        // the performance win of an early exit here is too good to pass up and worth
139
        // the extra risk.
140
91.2k
        if (mempool_count == shorttxids.size())
141
570
            break;
142
91.2k
    }
143
16.8k
    }
144
145
26.1k
    for (size_t i = 0; i < extra_txn.size(); i++) {
146
9.88k
        uint64_t shortid = cmpctblock.GetShortID(extra_txn[i].first);
147
9.88k
        std::unordered_map<uint64_t, uint16_t>::iterator idit = shorttxids.find(shortid);
148
9.88k
        if (idit != shorttxids.end()) {
149
299
            if (!have_txn[idit->second]) {
150
289
                txn_available[idit->second] = extra_txn[i].second;
151
289
                have_txn[idit->second]  = true;
152
289
                mempool_count++;
153
289
                extra_count++;
154
289
            } else {
155
                // If we find two mempool/extra txn that match the short id, just
156
                // request it.
157
                // This should be rare enough that the extra bandwidth doesn't matter,
158
                // but eating a round-trip due to FillBlock failure would be annoying
159
                // Note that we don't want duplication between extra_txn and mempool to
160
                // trigger this case, so we compare witness hashes first
161
10
                if (txn_available[idit->second] &&
162
10
                        txn_available[idit->second]->GetWitnessHash() != extra_txn[i].second->GetWitnessHash()) {
163
0
                    txn_available[idit->second].reset();
164
0
                    mempool_count--;
165
0
                    extra_count--;
166
0
                }
167
10
            }
168
299
        }
169
        // Though ideally we'd continue scanning for the two-txn-match-shortid case,
170
        // the performance win of an early exit here is too good to pass up and worth
171
        // the extra risk.
172
9.88k
        if (mempool_count == shorttxids.size())
173
622
            break;
174
9.88k
    }
175
176
16.8k
    LogDebug(BCLog::CMPCTBLOCK, "Initialized PartiallyDownloadedBlock for block %s using a cmpctblock of %u bytes\n", cmpctblock.header.GetHash().ToString(), GetSerializeSize(cmpctblock));
177
178
16.8k
    return READ_STATUS_OK;
179
16.8k
}
180
181
bool PartiallyDownloadedBlock::IsTxAvailable(size_t index) const
182
30.1k
{
183
30.1k
    if (header.IsNull()) return false;
184
185
30.1k
    assert(index < txn_available.size());
186
30.1k
    return txn_available[index] != nullptr;
187
30.1k
}
188
189
ReadStatus PartiallyDownloadedBlock::FillBlock(CBlock& block, const std::vector<CTransactionRef>& vtx_missing, bool segwit_active)
190
16.8k
{
191
16.8k
    if (header.IsNull()) return READ_STATUS_INVALID;
192
193
16.8k
    block = header;
194
16.8k
    block.vtx.resize(txn_available.size());
195
196
16.8k
    size_t tx_missing_offset = 0;
197
46.8k
    for (size_t i = 0; i < txn_available.size(); i++) {
198
29.9k
        if (!txn_available[i]) {
199
1.55k
            if (tx_missing_offset >= vtx_missing.size()) {
200
2
                return READ_STATUS_INVALID;
201
2
            }
202
1.55k
            block.vtx[i] = vtx_missing[tx_missing_offset++];
203
28.4k
        } else {
204
28.4k
            block.vtx[i] = std::move(txn_available[i]);
205
28.4k
        }
206
29.9k
    }
207
208
    // Make sure we can't call FillBlock again.
209
16.8k
    header.SetNull();
210
16.8k
    txn_available.clear();
211
212
16.8k
    if (vtx_missing.size() != tx_missing_offset) {
213
0
        return READ_STATUS_INVALID;
214
0
    }
215
216
    // Check for possible mutations early now that we have a seemingly good block
217
16.8k
    IsBlockMutatedFn check_mutated{m_check_block_mutated_mock ? m_check_block_mutated_mock : IsBlockMutated};
218
16.8k
    if (check_mutated(/*block=*/block, /*check_witness_root=*/segwit_active)) {
219
6
        return READ_STATUS_FAILED; // Possible Short ID collision
220
6
    }
221
222
16.8k
    if (LogAcceptCategory(BCLog::CMPCTBLOCK, BCLog::Level::Debug)) {
223
16.8k
        const uint256 hash{block.GetHash()};
224
16.8k
        uint32_t tx_missing_size{0};
225
16.8k
        for (const auto& tx : vtx_missing) tx_missing_size += tx->ComputeTotalSize();
226
16.8k
        LogDebug(BCLog::CMPCTBLOCK, "Successfully reconstructed block %s with %u txn prefilled, %u txn from mempool (incl at least %u from extra pool) and %u txn (%u bytes) requested\n", hash.ToString(), prefilled_count, mempool_count, extra_count, vtx_missing.size(), tx_missing_size);
227
16.8k
        if (vtx_missing.size() < 5) {
228
16.8k
            for (const auto& tx : vtx_missing) {
229
726
                LogDebug(BCLog::CMPCTBLOCK, "Reconstructed block %s required tx %s\n", hash.ToString(), tx->GetHash().ToString());
230
726
            }
231
16.8k
        }
232
16.8k
    }
233
234
16.8k
    return READ_STATUS_OK;
235
16.8k
}