Coverage Report

Created: 2026-08-05 14:35

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
/tmp/bitcoin/src/common/config.cpp
Line
Count
Source
1
// Copyright (c) 2023-present The Bitcoin Core developers
2
// Distributed under the MIT software license, see the accompanying
3
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
4
5
#include <common/args.h> // IWYU pragma: associated
6
7
#include <common/settings.h>
8
#include <sync.h>
9
#include <tinyformat.h>
10
#include <univalue.h>
11
#include <util/check.h>
12
#include <util/fs.h>
13
#include <util/log.h>
14
#include <util/string.h>
15
16
#include <algorithm>
17
#include <cstdlib>
18
#include <fstream>
19
#include <iostream>
20
#include <list>
21
#include <map>
22
#include <optional>
23
#include <sstream>
24
#include <string>
25
#include <string_view>
26
#include <utility>
27
#include <vector>
28
29
using util::TrimString;
30
using util::TrimStringView;
31
32
static bool GetConfigOptions(std::istream& stream, const std::string& filepath, std::string& error, std::vector<std::pair<std::string, std::string>>& options, std::list<SectionInfo>& sections)
33
51.2k
{
34
51.2k
    std::string str, prefix;
35
51.2k
    std::string::size_type pos;
36
51.2k
    int linenr = 1;
37
292k
    while (std::getline(stream, str)) {
38
240k
        bool used_hash = false;
39
240k
        if ((pos = str.find('#')) != std::string::npos) {
40
26
            str = str.substr(0, pos);
41
26
            used_hash = true;
42
26
        }
43
240k
        const static std::string pattern = " \t\r\n";
44
240k
        str = TrimString(str, pattern);
45
240k
        if (!str.empty()) {
46
240k
            if (*str.begin() == '[' && *str.rbegin() == ']') {
47
2.32k
                const std::string section = str.substr(1, str.size() - 2);
48
2.32k
                sections.emplace_back(SectionInfo{section, filepath, linenr});
49
2.32k
                prefix = section + '.';
50
238k
            } else if (*str.begin() == '-') {
51
1
                error = strprintf("parse error on line %i: %s, options in configuration file must be specified without leading -", linenr, str);
52
1
                return false;
53
238k
            } else if ((pos = str.find('=')) != std::string::npos) {
54
238k
                std::string name = prefix + TrimString(std::string_view{str}.substr(0, pos), pattern);
55
238k
                std::string_view value = TrimStringView(std::string_view{str}.substr(pos + 1), pattern);
56
238k
                if (used_hash && name.find("rpcpassword") != std::string::npos) {
57
3
                    error = strprintf("parse error on line %i, using # in rpcpassword can be ambiguous and should be avoided", linenr);
58
3
                    return false;
59
3
                }
60
238k
                options.emplace_back(name, value);
61
238k
                if ((pos = name.rfind('.')) != std::string::npos && prefix.length() <= pos) {
62
91.3k
                    sections.emplace_back(SectionInfo{name.substr(0, pos), filepath, linenr});
63
91.3k
                }
64
238k
            } else {
65
2
                error = strprintf("parse error on line %i: %s", linenr, str);
66
2
                if (str.size() >= 2 && str.starts_with("no")) {
67
1
                    error += strprintf(", if you intended to specify a negated option, use %s=1 instead", str);
68
1
                }
69
2
                return false;
70
2
            }
71
240k
        }
72
240k
        ++linenr;
73
240k
    }
74
51.2k
    return true;
75
51.2k
}
76
77
238k
bool IsConfSupported(KeyInfo& key, std::string& error) {
78
238k
    if (key.name == "conf") {
79
2
        error = "conf cannot be set in the configuration file; use includeconf= if you want to include additional config files";
80
2
        return false;
81
2
    }
82
238k
    if (key.name == "reindex") {
83
        // reindex can be set in a config file but it is strongly discouraged as this will cause the node to reindex on
84
        // every restart. Allow the config but throw a warning
85
1
        LogWarning("reindex=1 is set in the configuration file, which will significantly slow down startup. Consider removing or commenting out this option for better performance, unless there is currently a condition which makes rebuilding the indexes necessary");
86
1
        return true;
87
1
    }
88
238k
    return true;
89
238k
}
90
91
bool ArgsManager::ReadConfigStream(std::istream& stream, const std::string& filepath, std::string& error, bool ignore_invalid_keys)
92
51.2k
{
93
51.2k
    LOCK(cs_args);
94
51.2k
    std::vector<std::pair<std::string, std::string>> options;
95
51.2k
    if (!GetConfigOptions(stream, filepath, error, options, m_config_sections)) {
96
6
        return false;
97
6
    }
98
238k
    for (const std::pair<std::string, std::string>& option : options) {
99
238k
        KeyInfo key = InterpretKey(option.first);
100
238k
        std::optional<unsigned int> flags = GetArgFlags_('-' + key.name);
101
238k
        if (!IsConfSupported(key, error)) return false;
102
238k
        if (flags) {
103
215k
            std::optional<common::SettingsValue> value = InterpretValue(key, &option.second, *flags, error);
104
215k
            if (!value) {
105
0
                return false;
106
0
            }
107
215k
            m_settings.ro_config[key.section][key.name].push_back(*value);
108
215k
        } else {
109
23.3k
            if (ignore_invalid_keys) {
110
23.3k
                LogWarning("Ignoring unknown configuration value %s", option.first);
111
23.3k
            } else {
112
0
                error = strprintf("Invalid configuration value %s", option.first);
113
0
                return false;
114
0
            }
115
23.3k
        }
116
238k
    }
117
51.2k
    return true;
118
51.2k
}
119
120
bool ArgsManager::ReadConfigString(const std::string& str_config)
121
14
{
122
14
    std::istringstream streamConfig(str_config);
123
14
    {
124
14
        LOCK(cs_args);
125
14
        m_settings.ro_config.clear();
126
14
        m_config_sections.clear();
127
14
    }
128
14
    std::string error;
129
14
    return ReadConfigStream(streamConfig, "", error);
130
14
}
131
132
bool ArgsManager::ReadConfigFiles(std::string& error, bool ignore_invalid_keys)
133
2.31k
{
134
2.31k
    {
135
2.31k
        LOCK(cs_args);
136
2.31k
        m_settings.ro_config.clear();
137
2.31k
        m_config_sections.clear();
138
2.31k
        const auto conf_val = GetPathArg_("-conf", BITCOIN_CONF_FILENAME);
139
2.31k
        m_config_path = (conf_val.is_absolute() || conf_val.empty()) ? conf_val : fsbridge::AbsPathJoin(GetDataDir(/*net_specific=*/false), conf_val);
140
2.31k
    }
141
142
2.31k
    const auto conf_path{GetConfigFilePath()};
143
2.31k
    std::ifstream stream;
144
2.31k
    if (!conf_path.empty()) { // path is empty when -noconf is specified
145
2.31k
        if (fs::is_directory(conf_path)) {
146
1
            error = strprintf("Config file \"%s\" is a directory.", fs::PathToString(conf_path));
147
1
            return false;
148
1
        }
149
2.31k
        stream = std::ifstream{conf_path.std_path()};
150
        // If the file is explicitly specified, it must be readable
151
2.31k
        if (IsArgSet("-conf") && !stream.good()) {
152
1
            error = strprintf("specified config file \"%s\" could not be opened.", fs::PathToString(conf_path));
153
1
            return false;
154
1
        }
155
2.31k
    }
156
    // ok to not have a config file
157
2.31k
    if (stream.good()) {
158
2.31k
        if (!ReadConfigStream(stream, fs::PathToString(conf_path), error, ignore_invalid_keys)) {
159
2
            return false;
160
2
        }
161
        // `-includeconf` cannot be included in the command line arguments except
162
        // as `-noincludeconf` (which indicates that no included conf file should be used).
163
2.31k
        bool use_conf_file{true};
164
2.31k
        {
165
2.31k
            LOCK(cs_args);
166
2.31k
            if (auto* includes = common::FindKey(m_settings.command_line_options, "includeconf")) {
167
                // ParseParameters() fails if a non-negated -includeconf is passed on the command-line
168
0
                assert(common::SettingsSpan(*includes).last_negated());
169
0
                use_conf_file = false;
170
0
            }
171
2.31k
        }
172
2.31k
        if (use_conf_file) {
173
2.31k
            std::string chain_id = GetChainTypeString();
174
2.31k
            std::vector<std::string> conf_file_names;
175
176
9.24k
            auto add_includes = [&](const std::string& network, size_t skip = 0) {
177
9.24k
                size_t num_values = 0;
178
9.24k
                LOCK(cs_args);
179
9.24k
                if (auto* section = common::FindKey(m_settings.ro_config, network)) {
180
9.21k
                    if (auto* values = common::FindKey(*section, "includeconf")) {
181
60
                        for (size_t i = std::max(skip, common::SettingsSpan(*values).negated()); i < values->size(); ++i) {
182
27
                            conf_file_names.push_back((*values)[i].get_str());
183
27
                        }
184
33
                        num_values = values->size();
185
33
                    }
186
9.21k
                }
187
9.24k
                return num_values;
188
9.24k
            };
189
190
            // We haven't set m_network yet (that happens in SelectParams()), so manually check
191
            // for network.includeconf args.
192
2.31k
            const size_t chain_includes = add_includes(chain_id);
193
2.31k
            const size_t default_includes = add_includes({});
194
195
2.31k
            for (const std::string& conf_file_name : conf_file_names) {
196
26
                const auto include_conf_path{AbsPathForConfigVal(*this, fs::PathFromString(conf_file_name), /*net_specific=*/false)};
197
26
                if (fs::is_directory(include_conf_path)) {
198
1
                    error = strprintf("Included config file \"%s\" is a directory.", fs::PathToString(include_conf_path));
199
1
                    return false;
200
1
                }
201
25
                std::ifstream conf_file_stream{include_conf_path.std_path()};
202
25
                if (conf_file_stream.good()) {
203
24
                    if (!ReadConfigStream(conf_file_stream, conf_file_name, error, ignore_invalid_keys)) {
204
6
                        return false;
205
6
                    }
206
18
                    LogInfo("Included configuration file %s\n", conf_file_name);
207
18
                } else {
208
1
                    error = "Failed to include configuration file " + conf_file_name;
209
1
                    return false;
210
1
                }
211
25
            }
212
213
            // Warn about recursive -includeconf
214
2.30k
            conf_file_names.clear();
215
2.30k
            add_includes(chain_id, /* skip= */ chain_includes);
216
2.30k
            add_includes({}, /* skip= */ default_includes);
217
2.30k
            std::string chain_id_final = GetChainTypeString();
218
2.30k
            if (chain_id_final != chain_id) {
219
                // Also warn about recursive includeconf for the chain that was specified in one of the includeconfs
220
0
                add_includes(chain_id_final);
221
0
            }
222
2.30k
            for (const std::string& conf_file_name : conf_file_names) {
223
1
                tfm::format(std::cerr, "warning: -includeconf cannot be used from included files; ignoring -includeconf=%s\n", conf_file_name);
224
1
            }
225
2.30k
        }
226
2.31k
    }
227
228
    // If datadir is changed in .conf file:
229
2.30k
    ClearPathCache();
230
2.30k
    if (!CheckDataDirOption(*this)) {
231
1
        error = strprintf("specified data directory \"%s\" does not exist.", GetArg("-datadir", ""));
232
1
        return false;
233
1
    }
234
2.30k
    return true;
235
2.30k
}
236
237
fs::path AbsPathForConfigVal(const ArgsManager& args, const fs::path& path, bool net_specific)
238
9.94k
{
239
9.94k
    if (path.is_absolute() || path.empty()) {
240
80
        return path;
241
80
    }
242
9.86k
    return fsbridge::AbsPathJoin(net_specific ? args.GetDataDirNet() : args.GetDataDirBase(), path);
243
9.94k
}