/tmp/bitcoin/src/wallet/feebumper.cpp
Line | Count | Source |
1 | | // Copyright (c) 2017-present The Bitcoin Core developers |
2 | | // Distributed under the MIT software license, see the accompanying |
3 | | // file COPYING or http://www.opensource.org/licenses/mit-license.php. |
4 | | |
5 | | #include <wallet/feebumper.h> |
6 | | |
7 | | #include <coins.h> |
8 | | #include <common/system.h> |
9 | | #include <consensus/validation.h> |
10 | | #include <interfaces/chain.h> |
11 | | #include <policy/policy.h> |
12 | | #include <util/moneystr.h> |
13 | | #include <util/rbf.h> |
14 | | #include <util/translation.h> |
15 | | #include <wallet/coincontrol.h> |
16 | | #include <wallet/fees.h> |
17 | | #include <wallet/receive.h> |
18 | | #include <wallet/spend.h> |
19 | | #include <wallet/wallet.h> |
20 | | |
21 | | namespace wallet { |
22 | | //! Check whether transaction has descendant in wallet or mempool, or has been |
23 | | //! mined, or conflicts with a mined transaction. Return a feebumper::Result. |
24 | | static feebumper::Result PreconditionChecks(const CWallet& wallet, const CWalletTx& wtx, bool require_mine, std::vector<bilingual_str>& errors) EXCLUSIVE_LOCKS_REQUIRED(wallet.cs_wallet) |
25 | 247 | { |
26 | 247 | if (wallet.HasWalletSpend(wtx.GetTx())) { |
27 | 2 | errors.emplace_back(Untranslated("Transaction has descendants in the wallet")); |
28 | 2 | return feebumper::Result::INVALID_PARAMETER; |
29 | 2 | } |
30 | | |
31 | 245 | { |
32 | 245 | if (wallet.chain().hasDescendantsInMempool(wtx.GetHash())) { |
33 | 1 | errors.emplace_back(Untranslated("Transaction has descendants in the mempool")); |
34 | 1 | return feebumper::Result::INVALID_PARAMETER; |
35 | 1 | } |
36 | 245 | } |
37 | | |
38 | 244 | if (wallet.GetTxDepthInMainChain(wtx) != 0) { |
39 | 0 | errors.emplace_back(Untranslated("Transaction has been mined, or is conflicted with a mined transaction")); |
40 | 0 | return feebumper::Result::WALLET_ERROR; |
41 | 0 | } |
42 | | |
43 | 244 | if (wtx.m_replaced_by_txid) { |
44 | 9 | errors.push_back(Untranslated(strprintf("Cannot bump transaction %s which was already bumped by transaction %s", wtx.GetHash().ToString(), wtx.m_replaced_by_txid->ToString()))); |
45 | 9 | return feebumper::Result::WALLET_ERROR; |
46 | 9 | } |
47 | | |
48 | 235 | if (require_mine) { |
49 | | // check that original tx consists entirely of our inputs |
50 | | // if not, we can't bump the fee, because the wallet has no way of knowing the value of the other inputs (thus the fee) |
51 | 122 | if (!AllInputsMine(wallet, *wtx.GetTx())) { |
52 | 1 | errors.emplace_back(Untranslated("Transaction contains inputs that don't belong to this wallet")); |
53 | 1 | return feebumper::Result::WALLET_ERROR; |
54 | 1 | } |
55 | 122 | } |
56 | | |
57 | 234 | return feebumper::Result::OK; |
58 | 235 | } |
59 | | |
60 | | //! Check if the user provided a valid feeRate |
61 | | static feebumper::Result CheckFeeRate(const CWallet& wallet, const CMutableTransaction& mtx, const CFeeRate& newFeerate, const int64_t maxTxSize, CAmount old_fee, std::vector<bilingual_str>& errors) |
62 | 39 | { |
63 | | // check that fee rate is higher than mempool's minimum fee |
64 | | // (no point in bumping fee if we know that the new tx won't be accepted to the mempool) |
65 | | // This may occur if fallbackfee is too low, or, perhaps, |
66 | | // in a rare situation where the mempool minimum fee increased significantly since the fee estimation just a |
67 | | // moment earlier. In this case, we report an error to the user, who may adjust the fee. |
68 | 39 | CFeeRate minMempoolFeeRate = wallet.chain().mempoolMinFee(); |
69 | | |
70 | 39 | if (newFeerate.GetFeePerK() < minMempoolFeeRate.GetFeePerK()) { |
71 | 0 | errors.push_back(Untranslated( |
72 | 0 | strprintf("New fee rate (%s) is lower than the minimum fee rate (%s) to get into the mempool -- ", |
73 | 0 | FormatMoney(newFeerate.GetFeePerK()), |
74 | 0 | FormatMoney(minMempoolFeeRate.GetFeePerK())))); |
75 | 0 | return feebumper::Result::WALLET_ERROR; |
76 | 0 | } |
77 | | |
78 | 39 | std::vector<COutPoint> reused_inputs; |
79 | 39 | reused_inputs.reserve(mtx.vin.size()); |
80 | 58 | for (const CTxIn& txin : mtx.vin) { |
81 | 58 | reused_inputs.push_back(txin.prevout); |
82 | 58 | } |
83 | | |
84 | 39 | const std::optional<CAmount> combined_bump_fee = wallet.chain().calculateCombinedBumpFee(reused_inputs, newFeerate); |
85 | 39 | if (!combined_bump_fee.has_value()) { |
86 | 1 | errors.push_back(Untranslated(strprintf("Failed to calculate bump fees, because unconfirmed UTXOs depend on an enormous cluster of unconfirmed transactions."))); |
87 | 1 | return feebumper::Result::WALLET_ERROR; |
88 | 1 | } |
89 | 38 | CAmount new_total_fee = newFeerate.GetFee(maxTxSize) + combined_bump_fee.value(); |
90 | | |
91 | 38 | CFeeRate incrementalRelayFee = wallet.chain().relayIncrementalFee(); |
92 | | |
93 | | // Min total fee is old fee + relay fee |
94 | 38 | CAmount minTotalFee = old_fee + incrementalRelayFee.GetFee(maxTxSize); |
95 | | |
96 | 38 | if (new_total_fee < minTotalFee) { |
97 | 11 | errors.push_back(Untranslated(strprintf("Insufficient total fee %s, must be at least %s (oldFee %s + incrementalFee %s)", |
98 | 11 | FormatMoney(new_total_fee), FormatMoney(minTotalFee), FormatMoney(old_fee), FormatMoney(incrementalRelayFee.GetFee(maxTxSize))))); |
99 | 11 | return feebumper::Result::INVALID_PARAMETER; |
100 | 11 | } |
101 | | |
102 | 27 | CAmount requiredFee = GetRequiredFee(wallet, maxTxSize); |
103 | 27 | if (new_total_fee < requiredFee) { |
104 | 0 | errors.push_back(Untranslated(strprintf("Insufficient total fee (cannot be less than required fee %s)", |
105 | 0 | FormatMoney(requiredFee)))); |
106 | 0 | return feebumper::Result::INVALID_PARAMETER; |
107 | 0 | } |
108 | | |
109 | 27 | const CFeeRate new_feerate{new_total_fee, static_cast<int32_t>(maxTxSize)}; |
110 | 27 | if (new_feerate > wallet.m_max_tx_fee_rate) { |
111 | 2 | errors.push_back(Untranslated(strprintf("New fee rate %s %s/kvB is too high (cannot be higher than -maxfeerate %s %s/kvB)", |
112 | 2 | FormatMoney(new_feerate.GetFeePerK()), CURRENCY_UNIT, FormatMoney(wallet.m_max_tx_fee_rate.GetFeePerK()), CURRENCY_UNIT))); |
113 | 2 | return feebumper::Result::WALLET_ERROR; |
114 | 2 | } |
115 | | |
116 | | // Check that in all cases the new fee doesn't violate maxTxFee |
117 | 25 | const CAmount max_tx_fee = wallet.m_max_tx_fee; |
118 | 25 | if (new_total_fee > max_tx_fee) { |
119 | 1 | errors.push_back(Untranslated(strprintf("Specified or calculated fee %s is too high (cannot be higher than -maxtxfee %s)", |
120 | 1 | FormatMoney(new_total_fee), FormatMoney(max_tx_fee)))); |
121 | 1 | return feebumper::Result::WALLET_ERROR; |
122 | 1 | } |
123 | | |
124 | 24 | return feebumper::Result::OK; |
125 | 25 | } |
126 | | |
127 | | static CFeeRate EstimateFeeRate(const CWallet& wallet, const CWalletTx& wtx, const CAmount old_fee, const CCoinControl& coin_control) |
128 | 91 | { |
129 | | // Get the fee rate of the original transaction. This is calculated from |
130 | | // the tx fee/vsize, so it may have been rounded down. Add 1 satoshi to the |
131 | | // result. |
132 | 91 | int64_t txSize = GetVirtualTransactionSize(*(wtx.GetTx())); |
133 | 91 | CFeeRate feerate(old_fee, txSize); |
134 | 91 | feerate += CFeeRate(1); |
135 | | |
136 | | // The node has a configurable incremental relay fee. Increment the fee by |
137 | | // the minimum of that and the wallet's conservative |
138 | | // WALLET_INCREMENTAL_RELAY_FEE value to future proof against changes to |
139 | | // network wide policy for incremental relay fee that our node may not be |
140 | | // aware of. This ensures we're over the required relay fee rate |
141 | | // (Rule 4). The replacement tx will be at least as large as the |
142 | | // original tx, so the total fee will be greater (Rule 3) |
143 | 91 | CFeeRate node_incremental_relay_fee = wallet.chain().relayIncrementalFee(); |
144 | 91 | CFeeRate wallet_incremental_relay_fee = CFeeRate(WALLET_INCREMENTAL_RELAY_FEE); |
145 | 91 | feerate += std::max(node_incremental_relay_fee, wallet_incremental_relay_fee); |
146 | | |
147 | | // Fee rate must also be at least the wallet's GetMinimumFeeRate |
148 | 91 | CFeeRate min_feerate(GetMinimumFeeRate(wallet, coin_control).fee_rate); |
149 | | |
150 | | // Set the required fee rate for the replacement transaction in coin control. |
151 | 91 | return std::max(feerate, min_feerate); |
152 | 91 | } |
153 | | |
154 | | namespace feebumper { |
155 | | |
156 | | bool TransactionCanBeBumped(const CWallet& wallet, const Txid& txid) |
157 | 0 | { |
158 | 0 | LOCK(wallet.cs_wallet); |
159 | 0 | const CWalletTx* wtx = wallet.GetWalletTx(txid); |
160 | 0 | if (wtx == nullptr) return false; |
161 | | |
162 | 0 | std::vector<bilingual_str> errors_dummy; |
163 | 0 | feebumper::Result res = PreconditionChecks(wallet, *wtx, /* require_mine=*/ true, errors_dummy); |
164 | 0 | return res == feebumper::Result::OK; |
165 | 0 | } |
166 | | |
167 | | Result CreateRateBumpTransaction(CWallet& wallet, const Txid& txid, const CCoinControl& coin_control, std::vector<bilingual_str>& errors, |
168 | | CAmount& old_fee, CAmount& new_fee, CMutableTransaction& mtx, bool require_mine, const std::vector<CTxOut>& outputs, std::optional<uint32_t> original_change_index) |
169 | 146 | { |
170 | | // For now, cannot specify both new outputs to use and an output index to send change |
171 | 146 | if (!outputs.empty() && original_change_index.has_value()) { |
172 | 1 | errors.emplace_back(Untranslated("The options 'outputs' and 'original_change_index' are incompatible. You can only either specify a new set of outputs, or designate a change output to be recycled.")); |
173 | 1 | return Result::INVALID_PARAMETER; |
174 | 1 | } |
175 | | |
176 | | // We are going to modify coin control later, copy to reuse |
177 | 145 | CCoinControl new_coin_control(coin_control); |
178 | | |
179 | 145 | LOCK(wallet.cs_wallet); |
180 | 145 | errors.clear(); |
181 | 145 | auto it = wallet.mapWallet.find(txid); |
182 | 145 | if (it == wallet.mapWallet.end()) { |
183 | 0 | errors.emplace_back(Untranslated("Invalid or non-wallet transaction id")); |
184 | 0 | return Result::INVALID_ADDRESS_OR_KEY; |
185 | 0 | } |
186 | 145 | const CWalletTx& wtx = it->second; |
187 | 145 | const CTransactionRef& tx = wtx.GetTx(); |
188 | | |
189 | | // Make sure that original_change_index is valid |
190 | 145 | if (original_change_index.has_value() && original_change_index.value() >= tx->vout.size()) { |
191 | 1 | errors.emplace_back(Untranslated("Change position is out of range")); |
192 | 1 | return Result::INVALID_PARAMETER; |
193 | 1 | } |
194 | | |
195 | | // Retrieve all of the UTXOs and add them to coin control |
196 | | // While we're here, calculate the input amount |
197 | 144 | std::map<COutPoint, Coin> coins; |
198 | 144 | CAmount input_value = 0; |
199 | 144 | std::vector<CTxOut> spent_outputs; |
200 | 318 | for (const CTxIn& txin : tx->vin) { |
201 | 318 | coins[txin.prevout]; // Create empty map entry keyed by prevout. |
202 | 318 | } |
203 | 144 | wallet.chain().findCoins(coins); |
204 | 318 | for (const CTxIn& txin : tx->vin) { |
205 | 318 | const Coin& coin = coins.at(txin.prevout); |
206 | 318 | if (coin.out.IsNull()) { |
207 | 1 | errors.emplace_back(Untranslated(strprintf("%s:%u is already spent", txin.prevout.hash.GetHex(), txin.prevout.n))); |
208 | 1 | return Result::MISC_ERROR; |
209 | 1 | } |
210 | 317 | PreselectedInput& preset_txin = new_coin_control.Select(txin.prevout); |
211 | 317 | if (!wallet.IsMine(txin.prevout)) { |
212 | 3 | preset_txin.SetTxOut(coin.out); |
213 | 3 | } |
214 | 317 | input_value += coin.out.nValue; |
215 | 317 | spent_outputs.push_back(coin.out); |
216 | 317 | } |
217 | | |
218 | | // Figure out if we need to compute the input weight, and do so if necessary |
219 | 143 | PrecomputedTransactionData txdata; |
220 | 143 | txdata.Init(*tx, std::move(spent_outputs), /* force=*/ true); |
221 | 460 | for (unsigned int i = 0; i < tx->vin.size(); ++i) { |
222 | 317 | const CTxIn& txin = tx->vin.at(i); |
223 | 317 | const Coin& coin = coins.at(txin.prevout); |
224 | | |
225 | 317 | if (new_coin_control.IsExternalSelected(txin.prevout)) { |
226 | | // For external inputs, we estimate the size using the size of this input |
227 | 3 | int64_t input_weight = GetTransactionInputWeight(txin); |
228 | | // Because signatures can have different sizes, we need to figure out all of the |
229 | | // signature sizes and replace them with the max sized signature. |
230 | | // In order to do this, we verify the script with a special SignatureChecker which |
231 | | // will observe the signatures verified and record their sizes. |
232 | 3 | SignatureWeights weights; |
233 | 3 | TransactionSignatureChecker tx_checker(tx.get(), i, coin.out.nValue, txdata, MissingDataBehavior::FAIL); |
234 | 3 | SignatureWeightChecker size_checker(weights, tx_checker); |
235 | 3 | VerifyScript(txin.scriptSig, coin.out.scriptPubKey, &txin.scriptWitness, STANDARD_SCRIPT_VERIFY_FLAGS, size_checker); |
236 | | // Add the difference between max and current to input_weight so that it represents the largest the input could be |
237 | 3 | input_weight += weights.GetWeightDiffToMax(); |
238 | 3 | new_coin_control.SetInputWeight(txin.prevout, input_weight); |
239 | 3 | } |
240 | 317 | } |
241 | | |
242 | 143 | Result result = PreconditionChecks(wallet, wtx, require_mine, errors); |
243 | 143 | if (result != Result::OK) { |
244 | 13 | return result; |
245 | 13 | } |
246 | | |
247 | | // Calculate the old output amount. |
248 | 130 | CAmount output_value = 0; |
249 | 349 | for (const auto& old_output : tx->vout) { |
250 | 349 | output_value += old_output.nValue; |
251 | 349 | } |
252 | | |
253 | 130 | old_fee = input_value - output_value; |
254 | | |
255 | | // Fill in recipients (and preserve a single change key if there |
256 | | // is one). If outputs vector is non-empty, replace original |
257 | | // outputs with its contents, otherwise use original outputs. |
258 | 130 | std::vector<CRecipient> recipients; |
259 | 130 | CAmount new_outputs_value = 0; |
260 | 130 | const auto& txouts = outputs.empty() ? tx->vout : outputs; |
261 | 375 | for (size_t i = 0; i < txouts.size(); ++i) { |
262 | 245 | const CTxOut& output = txouts.at(i); |
263 | 245 | CTxDestination dest; |
264 | 245 | ExtractDestination(output.scriptPubKey, dest); |
265 | 245 | if (original_change_index.has_value() ? original_change_index.value() == i : OutputIsChange(wallet, output)) { |
266 | 120 | new_coin_control.destChange = dest; |
267 | 125 | } else { |
268 | 125 | CRecipient recipient = {dest, output.nValue, false}; |
269 | 125 | recipients.push_back(recipient); |
270 | 125 | } |
271 | 245 | new_outputs_value += output.nValue; |
272 | 245 | } |
273 | | |
274 | | // If no recipients, means that we are sending coins to a change address |
275 | 130 | if (recipients.empty()) { |
276 | | // Just as a sanity check, ensure that the change address exist |
277 | 5 | if (std::get_if<CNoDestination>(&new_coin_control.destChange)) { |
278 | 0 | errors.emplace_back(Untranslated("Unable to create transaction. Transaction must have at least one recipient")); |
279 | 0 | return Result::INVALID_PARAMETER; |
280 | 0 | } |
281 | | |
282 | | // Add change as recipient with SFFO flag enabled, so fees are deduced from it. |
283 | | // If the output differs from the original tx output (because the user customized it) a new change output will be created. |
284 | 5 | recipients.emplace_back(CRecipient{new_coin_control.destChange, new_outputs_value, /*fSubtractFeeFromAmount=*/true}); |
285 | 5 | new_coin_control.destChange = CNoDestination(); |
286 | 5 | } |
287 | | |
288 | 130 | if (coin_control.m_feerate) { |
289 | | // The user provided a feeRate argument. |
290 | | // We calculate this here to avoid compiler warning on the cs_wallet lock |
291 | | // We need to make a temporary transaction with no input witnesses as the dummy signer expects them to be empty for external inputs |
292 | 39 | CMutableTransaction temp_mtx{*tx}; |
293 | 58 | for (auto& txin : temp_mtx.vin) { |
294 | 58 | txin.scriptSig.clear(); |
295 | 58 | txin.scriptWitness.SetNull(); |
296 | 58 | } |
297 | 39 | temp_mtx.vout = txouts; |
298 | 39 | const int64_t maxTxSize{CalculateMaximumSignedTxSize(CTransaction(temp_mtx), &wallet, &new_coin_control).vsize}; |
299 | 39 | Result res = CheckFeeRate(wallet, temp_mtx, *new_coin_control.m_feerate, maxTxSize, old_fee, errors); |
300 | 39 | if (res != Result::OK) { |
301 | 15 | return res; |
302 | 15 | } |
303 | 91 | } else { |
304 | | // The user did not provide a feeRate argument |
305 | 91 | new_coin_control.m_feerate = EstimateFeeRate(wallet, wtx, old_fee, new_coin_control); |
306 | 91 | } |
307 | | |
308 | | // Fill in required inputs we are double-spending(all of them) |
309 | | // N.B.: bip125 doesn't require all the inputs in the replaced transaction to be |
310 | | // used in the replacement transaction, but it's very important for wallets to make |
311 | | // sure that happens. If not, it would be possible to bump a transaction A twice to |
312 | | // A2 and A3 where A2 and A3 don't conflict (or alternatively bump A to A2 and A2 |
313 | | // to A3 where A and A3 don't conflict). If both later get confirmed then the sender |
314 | | // has accidentally double paid. |
315 | 271 | for (const auto& inputs : tx->vin) { |
316 | 271 | new_coin_control.Select(COutPoint(inputs.prevout)); |
317 | 271 | } |
318 | 115 | new_coin_control.m_allow_other_inputs = true; |
319 | | |
320 | | // We cannot source new unconfirmed inputs(bip125 rule 2) |
321 | 115 | new_coin_control.m_min_depth = 1; |
322 | | |
323 | 115 | auto res = CreateTransaction(wallet, recipients, /*change_pos=*/std::nullopt, new_coin_control, false); |
324 | 115 | if (!res) { |
325 | 2 | errors.emplace_back(Untranslated("Unable to create transaction.") + Untranslated(" ") + util::ErrorString(res)); |
326 | 2 | return Result::WALLET_ERROR; |
327 | 2 | } |
328 | | |
329 | 113 | const auto& txr = *res; |
330 | | // Write back new fee if successful |
331 | 113 | new_fee = txr.fee; |
332 | | |
333 | | // Write back transaction |
334 | 113 | mtx = CMutableTransaction(*txr.tx); |
335 | | |
336 | 113 | return Result::OK; |
337 | 115 | } |
338 | | |
339 | 104 | bool SignTransaction(CWallet& wallet, CMutableTransaction& mtx) { |
340 | 104 | LOCK(wallet.cs_wallet); |
341 | | |
342 | 104 | if (wallet.IsWalletFlagSet(WALLET_FLAG_EXTERNAL_SIGNER)) { |
343 | | // Make a blank psbt |
344 | 1 | PartiallySignedTransaction psbtx(mtx); |
345 | | |
346 | | // First fill transaction with our data without signing, |
347 | | // so external signers are not asked to sign more than once. |
348 | 1 | bool complete; |
349 | 1 | wallet.FillPSBT(psbtx, {.sign = false, .bip32_derivs = true}, complete); |
350 | 1 | auto err{wallet.FillPSBT(psbtx, {.sign = true, .bip32_derivs = false}, complete)}; |
351 | 1 | if (err) return false; |
352 | 1 | complete = FinalizeAndExtractPSBT(psbtx, mtx); |
353 | 1 | return complete; |
354 | 103 | } else { |
355 | 103 | return wallet.SignTransaction(mtx); |
356 | 103 | } |
357 | 104 | } |
358 | | |
359 | | Result CommitTransaction(CWallet& wallet, const Txid& txid, CMutableTransaction&& mtx, std::vector<bilingual_str>& errors, Txid& bumped_txid) |
360 | 104 | { |
361 | 104 | LOCK(wallet.cs_wallet); |
362 | 104 | if (!errors.empty()) { |
363 | 0 | return Result::MISC_ERROR; |
364 | 0 | } |
365 | 104 | auto it = txid.IsNull() ? wallet.mapWallet.end() : wallet.mapWallet.find(txid); |
366 | 104 | if (it == wallet.mapWallet.end()) { |
367 | 0 | errors.emplace_back(Untranslated("Invalid or non-wallet transaction id")); |
368 | 0 | return Result::MISC_ERROR; |
369 | 0 | } |
370 | 104 | const CWalletTx& oldWtx = it->second; |
371 | | |
372 | | // make sure the transaction still has no descendants and hasn't been mined in the meantime |
373 | 104 | Result result = PreconditionChecks(wallet, oldWtx, /* require_mine=*/ false, errors); |
374 | 104 | if (result != Result::OK) { |
375 | 0 | return result; |
376 | 0 | } |
377 | | |
378 | | // commit/broadcast the tx |
379 | 104 | CTransactionRef tx = MakeTransactionRef(std::move(mtx)); |
380 | 104 | wallet.CommitTransaction(tx, oldWtx.GetHash(), oldWtx.m_comment, oldWtx.m_comment_to, oldWtx.m_messages, oldWtx.m_payment_requests); |
381 | | |
382 | | // mark the original tx as bumped |
383 | 104 | bumped_txid = tx->GetHash(); |
384 | 104 | if (!wallet.MarkReplaced(oldWtx.GetHash(), bumped_txid)) { |
385 | 0 | errors.emplace_back(Untranslated("Created new bumpfee transaction but could not mark the original transaction as replaced")); |
386 | 0 | } |
387 | 104 | return Result::OK; |
388 | 104 | } |
389 | | |
390 | | } // namespace feebumper |
391 | | } // namespace wallet |