/tmp/bitcoin/src/wallet/test/spend_tests.cpp
Line | Count | Source |
1 | | // Copyright (c) 2021-present The Bitcoin Core developers |
2 | | // Distributed under the MIT software license, see the accompanying |
3 | | // file COPYING or http://www.opensource.org/licenses/mit-license.php. |
4 | | |
5 | | #include <consensus/amount.h> |
6 | | #include <key.h> |
7 | | #include <script/solver.h> |
8 | | #include <validation.h> |
9 | | #include <wallet/coincontrol.h> |
10 | | #include <wallet/spend.h> |
11 | | #include <wallet/test/util.h> |
12 | | #include <wallet/test/wallet_test_fixture.h> |
13 | | |
14 | | #include <boost/test/unit_test.hpp> |
15 | | |
16 | | namespace wallet { |
17 | | BOOST_FIXTURE_TEST_SUITE(spend_tests, WalletTestingSetup) |
18 | | |
19 | | BOOST_AUTO_TEST_CASE(max_signed_input_size_uses_external_outpoint) |
20 | 1 | { |
21 | 1 | const CKey key{GenerateRandomKey()}; |
22 | 1 | FillableSigningProvider provider; |
23 | 1 | BOOST_REQUIRE(provider.AddKey(key)); |
24 | | |
25 | 1 | const CTxOut txout{COIN, GetScriptForDestination(PKHash{key.GetPubKey()})}; |
26 | 1 | const COutPoint outpoint{Txid{}, 0}; |
27 | 1 | CCoinControl coin_control; |
28 | 1 | coin_control.Select(outpoint).SetTxOut(txout); |
29 | | |
30 | 1 | const int low_r{CalculateMaximumSignedInputSize(txout, COutPoint{}, &provider, /*can_grind_r=*/true, &coin_control)}; |
31 | 1 | const int high_r{CalculateMaximumSignedInputSize(txout, outpoint, &provider, /*can_grind_r=*/true, &coin_control)}; |
32 | 1 | BOOST_CHECK_EQUAL(high_r, low_r + 1); |
33 | 1 | } |
34 | | |
35 | | BOOST_FIXTURE_TEST_CASE(SubtractFee, TestChain100Setup) |
36 | 1 | { |
37 | 1 | CreateAndProcessBlock({}, GetScriptForRawPubKey(coinbaseKey.GetPubKey())); |
38 | 1 | auto wallet = CreateSyncedWallet(*m_node.chain, WITH_LOCK(Assert(m_node.chainman)->GetMutex(), return m_node.chainman->ActiveChain()), coinbaseKey); |
39 | | |
40 | | // Check that a subtract-from-recipient transaction slightly less than the |
41 | | // coinbase input amount does not create a change output (because it would |
42 | | // be uneconomical to add and spend the output), and make sure it pays the |
43 | | // leftover input amount which would have been change to the recipient |
44 | | // instead of the miner. |
45 | 4 | auto check_tx = [&wallet](CAmount leftover_input_amount) { |
46 | 4 | CRecipient recipient{PubKeyDestination({}), 50 * COIN - leftover_input_amount, /*subtract_fee=*/true}; |
47 | 4 | CCoinControl coin_control; |
48 | 4 | coin_control.m_feerate.emplace(10000); |
49 | 4 | coin_control.fOverrideFeeRate = true; |
50 | | // We need to use a change type with high cost of change so that the leftover amount will be dropped to fee instead of added as a change output |
51 | 4 | coin_control.m_change_type = OutputType::LEGACY; |
52 | 4 | auto res = CreateTransaction(*wallet, {recipient}, /*change_pos=*/std::nullopt, coin_control); |
53 | 4 | BOOST_CHECK(res); |
54 | 4 | const auto& txr = *res; |
55 | 4 | BOOST_CHECK_EQUAL(txr.tx->vout.size(), 1); |
56 | 4 | BOOST_CHECK_EQUAL(txr.tx->vout[0].nValue, recipient.nAmount + leftover_input_amount - txr.fee); |
57 | 4 | BOOST_CHECK_GT(txr.fee, 0); |
58 | 4 | return txr.fee; |
59 | 4 | }; |
60 | | |
61 | | // Send full input amount to recipient, check that only nonzero fee is |
62 | | // subtracted (to_reduce == fee). |
63 | 1 | const CAmount fee{check_tx(0)}; |
64 | | |
65 | | // Send slightly less than full input amount to recipient, check leftover |
66 | | // input amount is paid to recipient not the miner (to_reduce == fee - 123) |
67 | 1 | BOOST_CHECK_EQUAL(fee, check_tx(123)); |
68 | | |
69 | | // Send full input minus fee amount to recipient, check leftover input |
70 | | // amount is paid to recipient not the miner (to_reduce == 0) |
71 | 1 | BOOST_CHECK_EQUAL(fee, check_tx(fee)); |
72 | | |
73 | | // Send full input minus more than the fee amount to recipient, check |
74 | | // leftover input amount is paid to recipient not the miner (to_reduce == |
75 | | // -123). This overpays the recipient instead of overpaying the miner more |
76 | | // than double the necessary fee. |
77 | 1 | BOOST_CHECK_EQUAL(fee, check_tx(fee + 123)); |
78 | 1 | } |
79 | | |
80 | | BOOST_FIXTURE_TEST_CASE(wallet_duplicated_preset_inputs_test, TestChain100Setup) |
81 | 1 | { |
82 | | // Verify that the wallet's Coin Selection process does not include pre-selected inputs twice in a transaction. |
83 | | |
84 | | // Add 4 spendable UTXO, 50 BTC each, to the wallet (total balance 200 BTC) |
85 | 5 | for (int i = 0; i < 4; i++) CreateAndProcessBlock({}, GetScriptForRawPubKey(coinbaseKey.GetPubKey())); |
86 | 1 | auto wallet = CreateSyncedWallet(*m_node.chain, WITH_LOCK(Assert(m_node.chainman)->GetMutex(), return m_node.chainman->ActiveChain()), coinbaseKey); |
87 | | |
88 | 1 | LOCK(wallet->cs_wallet); |
89 | 1 | auto available_coins = AvailableCoins(*wallet); |
90 | 1 | std::vector<COutput> coins = available_coins.All(); |
91 | | // Preselect the first 3 UTXO (150 BTC total) |
92 | 1 | std::set<COutPoint> preset_inputs = {coins[0].outpoint, coins[1].outpoint, coins[2].outpoint}; |
93 | | |
94 | | // Try to create a tx that spends more than what preset inputs + wallet selected inputs are covering for. |
95 | | // The wallet can cover up to 200 BTC, and the tx target is 299 BTC. |
96 | 1 | std::vector<CRecipient> recipients{{*Assert(wallet->GetNewDestination(OutputType::BECH32, "dummy")), |
97 | 1 | /*nAmount=*/299 * COIN, /*fSubtractFeeFromAmount=*/true}}; |
98 | 1 | CCoinControl coin_control; |
99 | 1 | coin_control.m_allow_other_inputs = true; |
100 | 3 | for (const auto& outpoint : preset_inputs) { |
101 | 3 | coin_control.Select(outpoint); |
102 | 3 | } |
103 | | |
104 | | // Attempt to send 299 BTC from a wallet that only has 200 BTC. The wallet should exclude |
105 | | // the preset inputs from the pool of available coins, realize that there is not enough |
106 | | // money to fund the 299 BTC payment, and fail with "Insufficient funds". |
107 | | // |
108 | | // Even with SFFO, the wallet can only afford to send 200 BTC. |
109 | | // If the wallet does not properly exclude preset inputs from the pool of available coins |
110 | | // prior to coin selection, it may create a transaction that does not fund the full payment |
111 | | // amount or, through SFFO, incorrectly reduce the recipient's amount by the difference |
112 | | // between the original target and the wrongly counted inputs (in this case 99 BTC) |
113 | | // so that the recipient's amount is no longer equal to the user's selected target of 299 BTC. |
114 | | |
115 | | // First case, use 'subtract_fee_from_outputs=true' |
116 | 1 | BOOST_CHECK(!CreateTransaction(*wallet, recipients, /*change_pos=*/std::nullopt, coin_control)); |
117 | | |
118 | | // Second case, don't use 'subtract_fee_from_outputs'. |
119 | 1 | recipients[0].fSubtractFeeFromAmount = false; |
120 | | BOOST_CHECK(!CreateTransaction(*wallet, recipients, /*change_pos=*/std::nullopt, coin_control)); |
121 | 1 | } |
122 | | |
123 | | BOOST_AUTO_TEST_SUITE_END() |
124 | | } // namespace wallet |